Fix rounding in test #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QGarchery
previously approved these changes
Oct 3, 2024
Yes, I'm trying to see how much is enough |
QGarchery
approved these changes
Oct 3, 2024
|
What's the max number of fuzz runs we can possibly set ? |
Don't know but it will be slow and your computer will be running super hot |
colin-morpho
approved these changes
Oct 3, 2024
|
I'm working on another big test refactoring PR and I was also fixing various rounding issues, including your fixes in my PR would be better imo |
Merged
|
Replaced by #74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was making tests fail locally for me (still disappointed by the inconsistency of the forge fuzzer, because apparently on GitHub everything was fine)